Add kj::yieldUntilWouldSleep() and EventLoopLocal #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverted to draft. Need to do this a bit differently. |
kentonv
force-pushed
the
kenton/yieldUntilWouldSleep
branch
from
91f5d02
to
acdca9b
Compare
kentonv
added a commit
to cloudflare/workerd
that referenced
this pull request
Oct 27, 2024
kentonv
force-pushed
the
kenton/yieldUntilWouldSleep
branch
from
f6fb3b1
to
584839b
Compare
kentonv
added a commit
to cloudflare/workerd
that referenced
this pull request
Oct 29, 2024
This goes further than kj::yieldUntilQueueEmpty() by also making sure the OS-level I/O queue (e.g. `epoll`) is empty.
Does the same thing as WaitScope::cancelAllDetached(), but sometimes it's easier to access the `EventLoop`.
It's like thread-local variables, except they are local to the current EventLoop instead.
The node we are waiting on can actually be destroyed and replaced during the wait -- that's why we do `setSelfPointer(&node)`, to allow it to be replaced. But `currentInner` was being set to point at the node itself. So this could become dangling. Instead, it should point at the self-pointer, so that it reflects any replacements.
kentonv
force-pushed
the
kenton/yieldUntilWouldSleep
branch
from
6fb62ee
to
6d1c6f2
Compare
kentonv
added a commit
to cloudflare/workerd
that referenced
this pull request
Nov 2, 2024
kentonv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes further than kj::yieldUntilQueueEmpty() by also making sure the OS-level I/O queue (e.g.
epoll) is empty.Also in this PR: EventLoopLocal, which is like thread_local but attached to the current EventLoop.
Hint: These are things needed for implementing green threads.