This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Pinning to patch-updates only for react-native and react-native-svg #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After attempting to upgrade to newer versions of react-native-svg (and also react-native), I found rendering problems on the charts in the example app:
Also, unfortunately we are using caret semver ranges in package.json for both react-native and react-native-svg which means that a person cloning this project and doing an
npm install
in the example app for the first time will pull react-native-svg version 4.6.1 rather than 4.4.1. Using tilde ranges will help pin updates on these two key dependencies to patch-level-only updates. This addresses #55 and eliminates the need for extra steps to work around it