Enhanced pie chart multicolor support, jest tests, & updated example sync util

[marzolfb]

• Added support for using multiple colors on Pie chart as discussed in Solution for issue #5 about custom colors #22
  • There are now 3 ways to specify chart colors (listed in order or precedence):
    • Via a color property on the object of each item in the data array
    • Via props.palette (existing way to do it)
    • Via props.options.palette (added for consistency in handling of other props.options values for charts)
• For pie chart specifically, added a new way to specify chart options/properties directly as props vs using the existing props.options approach
• Added our first Jest snapshot tests for the project - this is really just a starting point to show it can be done
  • Tests compare runtime snapshots vs snapshot data stored in repo to provide some safety that unintended changes aren't being introduced
  • Modified circleci config to kick off test execution on a push to the repo
• Removed util/watchman-update-example-src utility and replaced it with a new sync-rnpc script in the example directory (Approach borrowed from the example in react-native-router-flux)

[marzolfb]

One more thing to point out. If you try to run npm test on these changes (or if you look at the circleci npm test output), you will get a ton of warnings like this:

jest-haste-map: duplicate manual mock found:
  Module name: ErrorUtils
  Duplicate Mock path: /home/ubuntu/react-native-pathjs-charts/node_modules/react-native/node_modules/fbjs/lib/__mocks__/ErrorUtils.js
This warning is caused by two manual mock files with the same file name.
Jest will use the mock file found in: 
/home/ubuntu/react-native-pathjs-charts/node_modules/react-native/node_modules/fbjs/lib/__mocks__/ErrorUtils.js
 Please delete one of the following two files: 
 /home/ubuntu/react-native-pathjs-charts/node_modules/react-native/Libraries/Core/__mocks__/ErrorUtils.js
/home/ubuntu/react-native-pathjs-charts/node_modules/react-native/node_modules/fbjs/lib/__mocks__/ErrorUtils.js

Unfortunately, Jest doesn't really give you an option for avoiding these warnings - see this open issue.

[katscott]

couple questions

[katscott]

Is a ScrollView actually needed here? (i've not opened example app just yet to view this)

[marzolfb]

Not needed and was a bit accidental but I don't see it as harmful. It can actually be useful if someone changes the chart size beyond what can be rendered on one screen. Willing to change it back if you think it makes more sense?

[katscott]

I'd say it would probably make best sense as a specific scroll demo chart for a column bar chart... pie chart would not be as likely to scroll horizontally. :)

[marzolfb]

Completely fair point. I changed it back

[katscott]

The documentation for the old way was mostly removed, but doesn't look like readme was updated (remove old info and update with new)

[marzolfb]

Good catch! Done