This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Fix documentation for #8 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for updating the readme - this is helpful. Before I can accept this and merge it in, I need you to sign our Contributor License Agreement (CLA). This will take care of us for this PR and any future ones you may want to submit. |
|
Done |
|
Wonderful. Thank you. One more thing. Since the Example Data section of the readme is basically a straight copy/paste from the example/data.js file - could you update that file as well for consistency? At some point, that section in the readme should maybe just be a link to the example data directly rather than embedded as it is now. |
|
Done |
marzolfb
approved these changes
Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation for pie diagram