This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Fix #103 - cleanup x axis label offsets to avoid tie to chart offsets #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original (broken) implementation uses a svg group around the x axis
text label. The x and y coordinates for that svg group are driven off
the chart's margin left and top offset values respectively. The
implication of this is that when specifying left and/or top offsets for
the entire chart, it inadvertently makes the labels either not aligned
with its corresponding bars (if the margin left value is too big) or
makes the labels appear way below the x axis or not at all (if the
margin top value is too big).
This fix removes the seemingly unnecessary svg grouping with incorrect
positioning around the label and modifies the y value for the label. The
x value (which is the center of the label) remains positioned at the
center of the bar above that it corresponds with. The y value has been
modified to add a configurable offset value to the minY value for the
chart. If no offset value is configured via the option props the default
offset value is 20 which seems to provide a reasonable amount of spacing
below the x axis.