EXAMPLES.md corrections #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s() from EXAMPLES.md
JasonPoll
commented
Dec 30, 2023
| @@ -148,9 +145,6 @@ end | |||
| This spares one from having to figure out the correct escaping sequences for | |||
| something like "echo(:cat, '...?...', '> /etc/sudoers.d/yolo')". | |||
|
|
|||
| **Note:** The `upload!()` method doesn't honor the values of `within()`, `as()` | |||
| etc, this will be improved as the library matures, but we're not there yet. | |||
There was a problem hiding this comment.
This (and the above) appeared to be inaccurate based on my testing of #524.
JasonPoll
commented
Dec 30, 2023
| @@ -235,16 +230,16 @@ end | |||
|
|
|||
| ```ruby | |||
| # The default format is pretty, which outputs colored text | |||
| SSHKit.config.format = :pretty | |||
| SSHKit.config.use_format :pretty | |||
There was a problem hiding this comment.
These appeared to have never been updated in 2cb6326.
JasonPoll
commented
Dec 30, 2023
| @@ -254,7 +249,7 @@ module SSHKit | |||
| module Formatter | |||
| class MyFormatter < SSHKit::Formatter::Abstract | |||
| def write(obj) | |||
| case obj.is_a? SSHKit::Command | |||
| if obj.is_a? SSHKit::Command | |||
There was a problem hiding this comment.
At least with Ruby 3.2.2, this case produced an error:
SyntaxError: unexpected `end', expecting `when'
mattbrictson
requested changes
Dec 31, 2023
| @@ -254,7 +249,7 @@ module SSHKit | |||
| module Formatter | |||
| class MyFormatter < SSHKit::Formatter::Abstract | |||
| def write(obj) | |||
| case obj.is_a? SSHKit::Command | |||
| if obj.is_a? SSHKit::Command | |||
mattbrictson
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing and testing @mattbrictson 's #524, I found myself referencing
EXAMPLES.mdand noted some inaccuracies.Hoping it's ok to open this PR without a corresponding issue discussing this first.