Unpin mocha version and fix deprecation warnings for mocha v1.11.1 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The undocumented behaviour that was changed in v1.10.x has been reinstated in v1.11.1 with deprecation warnings. So running the tests against v1.11.1 (the latest version) should not result in any failures.
This change addresses the following deprecation warning:
Mocha deprecation warning at test/helper.rb:6:in `require': Require 'mocha/test_unit', 'mocha/minitest' or 'mocha/api' instead of 'mocha/setup'.
This addresses the following deprecation warning:
Mocha deprecation warning at test/unit/formatters/test_pretty.rb:118:in `test_can_write_to_output_which_just_supports_append': Explicitly include `<<` in Hash of stubbed methods vs return values, e.g. `stub(:<< => nil)`.
|
Thanks for the fix, this is a great PR. Congrats on your first contribution to the project! |
floehopper
deleted the
unpin-mocha-version-and-fix-deprecation-warnings-for-v1.11.1
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The undocumented behaviour that was changed in mocha v1.10.x has been reinstated in v1.11.1 albeit with deprecation warnings. Running the sshkit tests against mocha v1.11.1 (the latest version) allowed me to identify and fix two deprecation warnings, one of which was the cause of the problem in #479. I haven't attempted to run the functional tests locally, but hopefully your CI build will catch anything I've missed.