Allow to set RAILS_GROUPS for assets:precompile #135
Conversation
README.md
Outdated
| @@ -9,6 +9,7 @@ Some rails specific options. | |||
|
|
|||
| ```ruby | |||
| set :rails_env, 'staging' # If the environment differs from the stage name | |||
| set :rails_assets_groups, nil # RAILS_GROUPS env value for the assets:precompile task | |||
There was a problem hiding this comment.
Maybe we should name just rails_groups? May be confusing to have rails_assets_groups setting that corresponds to RAILS_GROUPS ENV variable.
There was a problem hiding this comment.
Not sure. I think it could be confusing, so someone can think this envvar is applied to ALL tasks. The main point is to add this RAILS_ENV only for assets:precompile.
If you think it's ok, i'll change. I don't think a lot of people use RAILS_GROUPS.
|
Is this PR still needed/desirable? |
|
I would use it, if merged. For now I define custom tasks. |
|
Thanks for writing back. I think this is worth merging. Can you rebase and fix the conflicts? ~~~If you could also add some documentation of this feature to the README, that would be great.~~~ I see you've already added the docs. Never mind! |
|
Rebased. |
|
Looks good. Thanks! ✨ |
updated #134
Sorry, opened #134 from other user.