Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): add methods to read/write descriptors #236

Merged
merged 5 commits into from
Nov 14, 2021

Conversation

trik
Copy link
Contributor

@trik trik commented Nov 10, 2021

Reading / writing descriptors could be useful when developing custom BLE services / characteristic.

In this commit:

  • expose descriptors uuids in getServices return value
  • add methods to read and write a descriptor value

@pwespi
Copy link
Member

pwespi commented Nov 14, 2021

Thank you so much! Great work!

I changed a few small things:

  • handle characteristics that don't have descriptors on web
  • fix ios by adding the methods to Plugin.m and add descriptor discovery

@pwespi pwespi changed the title feat: add methods to read/write descriptors feat(all): add methods to read/write descriptors Nov 14, 2021
@pwespi pwespi merged commit ea9dae3 into capacitor-community:main Nov 14, 2021
@pwespi
Copy link
Member

pwespi commented Nov 14, 2021

@all-contributors please add @trik for code

@allcontributors
Copy link
Contributor

@pwespi

I've put up a pull request to add @trik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants