Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dateOfBirth #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding dateOfBirth #59

wants to merge 3 commits into from

Conversation

renejeglinsky
Copy link
Contributor

I propose to add dateOfBirth as this is very common for at least data privacy scenarios (which is the context where I stumbled upon this)

@DanSchlachter
Copy link
Contributor

the question is if this needs to be in the base model or we extend the base model with dob when we do the data privacy scenarios. The issue is that when we add it here, all tutorials / screenshots etc. have to be adjusted or are out of sync @CHERIANS

@renejeglinsky
Copy link
Contributor Author

What would "out of sync" mean? I guess if that element isn't used in a tutorial it doesn't harm.
And yes, I know the pain of screenshots getting outdated, but should that hinder us from enhancing the sample? Is it better to have more complicated tutorials around data privacy, for example, which all need to extend the base model?
I guess dob could also be useful in other scenarios. But in the end it's your call.

@gopalanand333
Copy link
Contributor

@renejeglinsky We are planning a separate tutorial around data privacy. Are there any other use cases where we need this field. Otherwise we can include it as part of Data privacy tutorial

@renejeglinsky
Copy link
Contributor Author

From capire perspective I can only think about the data privacy topics where dob is needed.
Extending the base model is not the focus of data privacy and therefore I'd see a benefit in having dob in the base model. It removes a step that some users might not even be familiar with and for those users we'd need to explain what we're doing (even though that topic is explained elsewhere in capire).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants