chore: use ieee754compatible instead of string_decimals (#724)

postgres/lib/PostgresService.js

@@ -532,7 +532,7 @@ GROUP BY k
       Int64: expr => `cast(${expr} as varchar)`,
       // REVISIT: always cast to string in next major
       // Reading decimal as string to not loose precision
-      Decimal: cds.env.features.string_decimals ? expr => `cast(${expr} as varchar)` : undefined,
+      Decimal: cds.env.features.ieee754compatible ? expr => `cast(${expr} as varchar)` : undefined,
 
       // Convert point back to json format
       'cds.hana.ST_POINT': expr => `CASE WHEN (${expr}) IS NOT NULL THEN json_object('x':(${expr})[0],'y':(${expr})[1])::varchar END`,

postgres/test/ql.test.js

@@ -63,13 +63,13 @@ describe('QL to PostgreSQL', () => {
           .where({ abv: { '>': 1.0 } })
           .orderBy({ abv: 'desc' }),
       )
-      expect(beers[0].abv).to.equal(cds.env.features.string_decimals ? "5.9" : 5.9)
+      expect(beers[0].abv).to.equal(cds.env.features.ieee754compatible ? "5.9" : 5.9)
       const reverseBeers = await cds.run(
         SELECT.from(Beers)
           .where({ abv: { '>': 1.0 } })
           .orderBy({ abv: 'asc' }),
       )
-      expect(reverseBeers[0].abv).to.equal(cds.env.features.string_decimals ? "4.9" : 4.9)
+      expect(reverseBeers[0].abv).to.equal(cds.env.features.ieee754compatible ? "4.9" : 4.9)
     })
 
     test('-> with groupBy', async () => {

sqlite/lib/SQLiteService.js

@@ -220,7 +220,7 @@ class SQLiteService extends SQLService {
       Int64: expr => `CAST(${expr} as TEXT)`,
       // REVISIT: always cast to string in next major
       // Reading decimal as string to not loose precision
-      Decimal: cds.env.features.string_decimals ? expr => `CAST(${expr} as TEXT)` : undefined,
+      Decimal: cds.env.features.ieee754compatible ? expr => `CAST(${expr} as TEXT)` : undefined,
       // Binary is not allowed in json objects
       Binary: expr => `${expr} || ''`,
     }

test/bookshop/package.json

@@ -25,7 +25,6 @@
     },
     "features": {
       "odata_new_adapter": true,
-      "string_decimals": true,
       "ieee754compatible": true
     }
   }

test/compliance/resources/package.json

@@ -12,7 +12,6 @@
       }
     },
     "features": {
-      "string_decimals": true,
       "ieee754compatible": true
     }
   }