async.someLimit #548
Closed
async.someLimit #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking if a folder contains subfolders or not (fs.readdir -> fs.stat -> some(is_a_Folder)), getting crashes when listing Windows shares from Ubuntu VM. someLimit avoids the problem.
|
The general strategy for having async collection methods is to use async.mapLimit() and then use filter, some, every, etc.. on the result. However, having a someLimit() function that short-circuits would be handy... |
| @@ -582,6 +583,27 @@ async.some(['file1','file2','file3'], fs.exists, function(result){ | |||
|
|
|||
| --------------------------------------- | |||
|
|
|||
| <a name="someLimit" /> | |||
| ### someLimit(arr, limit iterator, callback) | |||
There was a problem hiding this comment.
I believe you need a comma between limit and iterator
@aearly would you reconsider if it adds pretty much no LOC |
|
I'd be happy with whatever implementation as long as it also includes lots of LOC in tests. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting crashes on file IO operations involving network shares. Since async.some is a wrapper for async.each, and async.eachLimit already exists, addition appears straightforward.