Fix setImmediate incompatibility with IE10 even when process and process.nextTick are defined

[louischatriot]

Hello,

This references issue #299 . The fix sent by @dougwilson (PR #317) only works if process or process.nextTick are not defined. This effectively assumes that in a browser context, process.nextTick is not defined, but that's not always the case. For example, if you use browserify to create a browser version of your code, process.nextTick can be defined and in that case IE10 raises the "Invalid calling object" error. That is the case with one of my projects (the javascript database NeDB, https://github.com/louischatriot/nedb).

So I just copy-pasted @dougwilson's fix in the right section and the issue is solved.

Cheers,
Louis

[dougwilson]

I suppose the function wrap would be needed in both places since there are things like browserify that either do not add setImmediate to the global, or that do not "fix" setImmediate to act like it does in Node.js (i.e. doesn't require it to be called as a method on the global).

[selfcontained]

👍 to this

[lukekarrys]

👍 I'm currently using my fork https://github.com/lukekarrys/async in a current project to get around this bug.

[KylePDavis]

+1

[diversario]

No, nothing overrides setImmediate anywhere in my code. Perhaps some modules I uses (sinon?..).

[dougwilson]

sinon overrides setImmediate, setTimeout, etc. if you use the fake timers feature. You can find various issues in the Sinon tracker: https://github.com/cjohansen/Sinon.JS/issues?q=setimmediate

[dougwilson]

@diversario , also, see sinonjs/sinon#561

[diversario]

Thanks, @dougwilson, that helps!