ensure q.workersList() contains items being processed [fixes #1428] #1429
+120
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, just in case, I ran the benchmarks for $ node perf/benchmark.js --grep queue
Latest tag is v2.4.1
Comparing v2.4.1 with current on Node v7.4.0
--------------------------------------
queue(1000) v2.4.1 x 581 ops/sec ±1.52% (31 runs sampled), 1.72ms per run
queue(1000) current x 606 ops/sec ±0.69% (32 runs sampled), 1.65ms per run
current is faster
--------------------------------------
queue(30000) v2.4.1 x 16.96 ops/sec ±2.82% (30 runs sampled), 59.0ms per run
queue(30000) current x 15.94 ops/sec ±2.28% (29 runs sampled), 62.7ms per run
v2.4.1 is faster
--------------------------------------
queue(100000) v2.4.1 x 4.11 ops/sec ±10.95% (9 runs sampled), 243ms per run
queue(100000) current x 4.22 ops/sec ±6.17% (9 runs sampled), 237ms per run
Tie
--------------------------------------
queue(200000) v2.4.1 x 2.10 ops/sec ±13.67% (5 runs sampled), 477ms per run
queue(200000) current x 2.07 ops/sec ±11.86% (5 runs sampled), 482ms per run
Tie
--------------------------------------
Both versions are about equal (781ms total vs. 784ms total)
Both versions won the same number of benchmarks (1 vs. 1) |
aearly
reviewed
Jun 8, 2017
| } | ||
|
|
||
| var q = async.queue(function(task, cb) { | ||
| expect( |
There was a problem hiding this comment.
Should we also assert that workersList().length === running() here?
There was a problem hiding this comment.
Added, thanks!
megawac
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns
q.workersList()andcargo.workersList()with the docs.workersList()is not really relevant in the context ofasync.cargo, as there will only be 1 worker running at a given time, but I would prefer to keep the behavior consistent between it andqueue.