We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What version of async are you using? v2.4.1
Which environment did the issue occur in (Node version/browser version) Node v8.0.0
What did you do? Please include a minimal reproducable case illustrating issue.
async.concat([1, 2, 3], (val, next) => { next(null, val % 2 ? val : 0); }, (err, result) => { console.log(result); // [1, 3] });
What did you expect to happen? If the function has the same functionality as Array.prototype.concat, it should be [1, 0, 3].
Array.prototype.concat
[1, 0, 3]
What was the actual result? [1, 3]
[1, 3]
Also I realized,
[].concat(0); // [0] [].concat(); // [] [].concat(undefined); // [undefined]
I would like to know how Async is going to support the functions. Thanks :)
The text was updated successfully, but these errors were encountered:
Looks like we're just doing a truthy check here, when we should actually do y == null:
y == null
https://github.com/caolan/async/blob/master/lib/internal/concat.js#L5
Sorry, something went wrong.
handle variadic and falsy results in concatLimit [fixes #1437]
1382f30
Sure, I'll follow the PR changes, thanks :)
e9b2855
No branches or pull requests
What version of async are you using?
v2.4.1
Which environment did the issue occur in (Node version/browser version)
Node v8.0.0
What did you do? Please include a minimal reproducable case illustrating issue.
What did you expect to happen?
If the function has the same functionality as
Array.prototype.concat
, it should be[1, 0, 3]
.What was the actual result?
[1, 3]
Also I realized,
I would like to know how Async is going to support the functions. Thanks :)
The text was updated successfully, but these errors were encountered: