🦄 refactor: Apply default implementation to ~JavetInspectorClient()

caoccao · Aug 20, 2024 · c26cdc7 · c26cdc7
1 parent a2b6dba
commit c26cdc7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/cpp/jni/javet_inspector.cpp b/cpp/jni/javet_inspector.cpp
@@ -140,9 +140,6 @@ namespace Javet {
             return v8Runtime->GetV8LocalContext();
         }
 
-        JavetInspectorClient::~JavetInspectorClient() {
-        }
-
         JavetInspectorChannel::JavetInspectorChannel(V8Runtime* v8Runtime, const jobject mV8Inspector) noexcept {
             this->mV8Inspector = mV8Inspector;
             this->v8Runtime = v8Runtime;

diff --git a/cpp/jni/javet_inspector.h b/cpp/jni/javet_inspector.h
@@ -57,7 +57,7 @@ namespace Javet {
             void quitMessageLoopOnPause() override;
             void runIfWaitingForDebugger(int contextGroupId) override;
             void runMessageLoopOnPause(int contextGroupId) override;
-            virtual ~JavetInspectorClient();
+            virtual ~JavetInspectorClient() = default;
         private:
             bool activateMessageLoop;
             jobject mV8Inspector;