feat: support github apps #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ou can make a right turn on a red light. -- Woody Allen
joscha
commented
May 7, 2021
joscha
commented
May 7, 2021
| @@ -10,6 +10,8 @@ const defaultConfig = { | |||
| plugins: [ | |||
| nodeResolve({ | |||
| preferBuiltins: true, | |||
| // see https://github.com/octokit/auth-app.js/issues/59#issuecomment-833985009 | |||
There was a problem hiding this comment.
joscha
commented
May 7, 2021
How can I miss you if you won't go away?
…ot into joscha/support-apps
joscha
commented
May 7, 2021
| @@ -0,0 +1,47 @@ | |||
| # Install and configure RocketBot | |||
There was a problem hiding this comment.
@grantnoble if you have a spare minute I'd love your 👀 on this, please.
grantnoble
previously approved these changes
May 7, 2021
docs/guides/install-and-configure.md
Outdated
|
|
||
| You will need a Buildkite API key | ||
|
|
||
| The will will need access to the scopes: |
There was a problem hiding this comment.
Can we combine this sentence into the previous?
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
joscha
commented
May 7, 2021
joscha
commented
May 7, 2021
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
Co-authored-by: Grant Noble <[email protected]>
joscha
commented
May 7, 2021
Co-authored-by: Grant Noble <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5