Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5987] Add expose-external configuration option #172

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Nov 26, 2024

This PR ports the changes of canonical/zookeeper-k8s-operator#116.

External access by setting up a service is specific to K8s charms, but this PR brings the following:

  • Configuration: the charm configuration is now validated using pydantic, similar to what we have on Kafka.
  • Charm lib: the ZooKeeper charm lib was looking for the ZK leader unit upon instantiating ZooKeeperManager. This behaviour is incompatible with an application-wide nodeport service that can route queries to any unit. The default behaviour is to look for any live ZK unit. We will need to publish this change before any client Charm can relate to ZK with expose-external set to something else than "false"
  • Relation interface: the endpoints relation field now properly concats the port to each ZK host

@Batalex Batalex self-assigned this Nov 26, 2024
@Batalex Batalex force-pushed the feat/dpe-5987-expose-external branch from 0feb93d to a8aab95 Compare November 27, 2024 09:10
@Batalex Batalex marked this pull request as ready for review November 27, 2024 09:11
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Thanks for backporting this!

@Batalex Batalex force-pushed the feat/dpe-5987-expose-external branch from a8aab95 to 95ebb31 Compare December 2, 2024 08:08
@Batalex Batalex merged commit 3b6aedf into main Dec 2, 2024
17 checks passed
@Batalex Batalex deleted the feat/dpe-5987-expose-external branch December 2, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants