[POC][IGNORE] Relation Data split from Event Handlers, accessible as dict #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
changed the title
juditnovak
force-pushed
the
poc_judit_dp_libs_experiment_events_split_dict
branch
3 times, most recently
from
b9e0eed to
459c737
Compare
juditnovak
force-pushed
the
poc_judit_dp_libs_experiment_events_split_dict
branch
from
459c737 to
8a4b52f
Compare
juditnovak
commented
Feb 21, 2024
| self.relation_data.update(update_content) | ||
|
|
||
| for field in delete_fields: | ||
| del self.relation_data[field] |
There was a problem hiding this comment.
...or we could just simply get rid of the whole update() method and use the "dict" directly.
Like databag ;-)
NOTE: With the current implementation I'm demonstrating above, we do raise an AttributeError on StateBase objects when no relation was passed, yet we wanna access relation data.
To me that makes sense, but we could think of alternatives if it seems bad for others.
Also, I think we could just turn relation into relation_id. That seems all possible (I checked references in the code) however if we wanna instantiate StateBase "children" objects with NO relation yet, then we've still gotta handle the "no relation ID/data" case.
|
POC, not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.