Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable Pebble health check timeout #238

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Adjustable Pebble health check timeout #238

merged 2 commits into from
Sep 13, 2024

Conversation

weiiwang01
Copy link
Collaborator

@weiiwang01 weiiwang01 commented Sep 10, 2024

Overview

Introduce a new configuration option, health_check_timeout_seconds, to customize the timeout value for WordPress in Pebble. Operators can use this setting to modify the threshold for health checks, tailoring it to the expected system performance and environmental conditions.

Related to #138

Checklist

cbartz
cbartz previously approved these changes Sep 11, 2024
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please use the pull request template?

@weiiwang01 weiiwang01 added the trivial This is a trivial PR label Sep 11, 2024
@weiiwang01
Copy link
Collaborator Author

LGTM, could you please use the pull request template?

Gotcha, I have update the pull request description based on your recommendations, thanks!

Copy link
Contributor

Test coverage for 0041e6e

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          556     35    190     34    91%   162, 204-207, 299->302, 414, 473->477, 626, 657, 663, 680-684, 714, 749-750, 808, 817, 921->934, 933, 935, 940-941, 1001, 1021, 1028, 1118, 1127, 1139, 1160, 1169, 1188, 1192, 1221, 1262, 1394, 1416, 1423->1425, 1468->exit, 1480, 1490, 1528
src/cos.py             20      0      0      0   100%
src/exceptions.py      16      1      2      1    89%   41
src/state.py           33      0      4      0   100%
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 640     36    196     35    92%

Static code analysis report

Run started:2024-09-11 11:30:47.554258

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4642
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 merged commit 94fddf0 into main Sep 13, 2024
31 checks passed
@weiiwang01 weiiwang01 deleted the adjustable-timeout branch September 13, 2024 10:08
@hloeung
Copy link

hloeung commented Sep 15, 2024

Unfortunately with this change, we still can't bump the timeout:

ops.pebble.APIError: plan check "wordpress-ready" timeout must be less than period

I think we need a bit to override and increase period1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants