Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql deploy #232

Merged
merged 4 commits into from
Jul 12, 2024
Merged

fix: mysql deploy #232

merged 4 commits into from
Jul 12, 2024

Conversation

yanksyoon
Copy link
Collaborator

Applicable spec: N/A

Overview

Fixes integration test

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@yanksyoon yanksyoon added bug Something isn't working trivial This is a trivial PR labels Jul 11, 2024
@yanksyoon yanksyoon marked this pull request as ready for review July 12, 2024 02:34
@yanksyoon yanksyoon requested a review from a team as a code owner July 12, 2024 02:34
@yanksyoon yanksyoon changed the title [WIP] fix: mysql deploy fix: mysql deploy Jul 12, 2024
Copy link
Contributor

Test coverage for b8a2332

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          537     35    184     33    91%   162, 203-206, 370, 429->433, 582, 613, 619, 636-640, 670, 705-706, 764, 773, 877->890, 889, 891, 896-897, 957, 977, 984, 1074, 1083, 1095, 1116, 1125, 1144, 1148, 1177, 1218, 1350, 1372, 1379->1381, 1424->exit, 1436, 1446, 1484
src/cos.py             20      0      0      0   100%
src/exceptions.py      16      1      2      1    89%   41
src/state.py           33      0      4      0   100%
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 621     36    190     34    91%

Static code analysis report

Run started:2024-07-12 02:45:22.384265

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4563
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon yanksyoon merged commit 2adb5c8 into main Jul 12, 2024
32 checks passed
@yanksyoon yanksyoon deleted the fix/integration branch July 12, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Libraries: Out of sync trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants