Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if the workload is accessible before running hook #561

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

DanielArndt
Copy link
Member

@DanielArndt DanielArndt commented Dec 11, 2024

This ensures that pebble is accessible before running the hook, otherwise we could get a pebble error when trying to do something like access the certificate in the workload.

This issue is currently causing plenty of integration test failures. This change appears to fix that.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DanielArndt DanielArndt force-pushed the check-for-pebble-connection branch 2 times, most recently from 35cb92d to 91305f7 Compare December 11, 2024 17:20
@DanielArndt DanielArndt marked this pull request as ready for review December 11, 2024 18:22
@DanielArndt DanielArndt requested a review from a team as a code owner December 11, 2024 18:22
@DanielArndt DanielArndt force-pushed the check-for-pebble-connection branch from 91305f7 to 34bcb44 Compare December 11, 2024 18:30
@DanielArndt DanielArndt enabled auto-merge (squash) December 12, 2024 11:12
@DanielArndt DanielArndt merged commit 21c13ca into main Dec 12, 2024
12 checks passed
@DanielArndt DanielArndt deleted the check-for-pebble-connection branch December 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants