Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use logger, not the root logger (logging) #547

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

DanielArndt
Copy link
Member

This is a bad habit I have that I blame on Django.

Unfortunately, the ruff check for this is still not stable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This is a bad habit I have that I blame on Django.

Unfortunately, the ruff check for this is still not stable.
@DanielArndt DanielArndt changed the title Use logger, not the root logger (logging) refactor: Use logger, not the root logger (logging) Nov 29, 2024
@DanielArndt DanielArndt marked this pull request as ready for review November 30, 2024 00:16
@DanielArndt DanielArndt requested a review from a team as a code owner November 30, 2024 00:16
@DanielArndt DanielArndt merged commit a57a5d2 into main Dec 2, 2024
12 checks passed
@DanielArndt DanielArndt deleted the fix-logging-calls branch December 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants