New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unnecessary check #533

Merged

DanielArndt merged 1 commit into main from remove-unnecessary-check

Nov 20, 2024

Member

DanielArndt commented Nov 19, 2024

The type hints already specify the type should be ops.Relation, so this shouldn't be necessary.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that validate the behaviour of the software
I validated that new and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          Type hints already state it should be ops.Relation

60caf3a

DanielArndt requested a review from a team as a code owner

November 19, 2024 19:03

ghislainbourgeois approved these changes

View reviewed changes

DanielArndt merged commit d196e31 into main

12 checks passed

DanielArndt deleted the remove-unnecessary-check branch

November 20, 2024 17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet