Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes unittest, so pytest operates as expected #514

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

DanielArndt
Copy link
Member

@DanielArndt DanielArndt commented Oct 9, 2024

Currently, we have a mashup of unittest and pytest.

Although the class inherits from unittest, we're using pytest to run the tests. This works fine in the basic cases, but doesn't work when you try to use any of the features of either framework. For example, neither pytest parameterize or unitttest subtests work.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Currently, we have a mashup of unittest and pytest.

Although the class inherits from unittest, we're using pytest to run
the tests. This works fine in the basic cases, but doesn't work when you
try to use any of the features of either framework. For example, neither
pytest parameterize or unitttest subtests work.
@DanielArndt DanielArndt marked this pull request as ready for review October 9, 2024 18:59
@DanielArndt DanielArndt requested a review from a team as a code owner October 9, 2024 18:59
@DanielArndt DanielArndt enabled auto-merge (squash) October 11, 2024 12:11
@DanielArndt DanielArndt merged commit 8dea58d into main Oct 11, 2024
11 checks passed
@DanielArndt DanielArndt deleted the remove-unittest branch October 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants