[Fix] Add subject and ingress address to subject alt names #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services reaching Vault from inside the K8S (no external addressing) use the loadbalancer primitives offered by K8S. Adding to Subject Alt Names: - Service name as DNS SAN - Ingress address (ClusterIP) as IP SAN
gruyaume
reviewed
Sep 19, 2023
gruyaume
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #37
Services reaching Vault from inside K8S (no external addressing) use the loadbalancer primitives offered by K8S.
Adding to Subject Alt Names:
Checklist:
Notes
I'm not sure that's the right way to handle, since current TLS handling does not handle scaling, TLS management will most likely evolve. Happy to discard if that's not wished.