Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Implements raft backend (HA) #35

Merged
merged 14 commits into from
Sep 12, 2023
Merged

[Feat] Implements raft backend (HA) #35

merged 14 commits into from
Sep 12, 2023

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Sep 6, 2023

Description

Implementation of HA leveraging the Raft backend. The leader initializes Vault and as unit gets added to the application, they look at the existing unit addresses from the peer relation data and use those in their configuration file to get added to the raft cluster.

Reference

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruyaume gruyaume marked this pull request as ready for review September 8, 2023 12:50
@gruyaume gruyaume requested a review from a team as a code owner September 8, 2023 12:50
src/charm.py Outdated Show resolved Hide resolved
@gruyaume gruyaume requested review from a team and ghislainbourgeois and removed request for a team September 8, 2023 15:55
src/charm.py Outdated Show resolved Hide resolved
src/vault.py Outdated Show resolved Hide resolved
tests/integration/test_integration.py Outdated Show resolved Hide resolved
tests/integration/test_integration.py Outdated Show resolved Hide resolved
@gruyaume gruyaume marked this pull request as draft September 12, 2023 11:12
@gruyaume gruyaume marked this pull request as ready for review September 12, 2023 12:54
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small question remaining

src/charm.py Outdated Show resolved Hide resolved
src/vault.py Show resolved Hide resolved
README.md Show resolved Hide resolved
tests/unit/test_vault.py Show resolved Hide resolved
@gruyaume gruyaume merged commit 3c9bf09 into main Sep 12, 2023
@gruyaume gruyaume deleted the telco-643-02 branch September 12, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants