Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes CI issues #13

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Fixes CI issues #13

merged 4 commits into from
Jan 19, 2023

Conversation

sanchezfdezjavier
Copy link
Contributor

@sanchezfdezjavier sanchezfdezjavier commented Jan 17, 2023 •
edited
Loading

Description

Fixes several CI issues:

  • Now we ignore the /lib directory during static analysis.
  • Changed integration tests to run in 20.04 instead of latest ubuntu version.
  • Specifies series="focal" when deploying the charm in the integration tests.
  • Reverts some packages to be fetched from Pypi from GitHub's main branch.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sanchezfdezjavier sanchezfdezjavier changed the title Changes Ubuntu runner version Fixes CI issues Jan 18, 2023
@sanchezfdezjavier sanchezfdezjavier marked this pull request as ready for review January 18, 2023 12:24
@sanchezfdezjavier sanchezfdezjavier merged commit 652ef30 into main Jan 19, 2023
@gruyaume gruyaume deleted the fix-ci-issues branch August 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

@saltiyazan saltiyazan saltiyazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanchezfdezjavier @gruyaume @saltiyazan