Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case study #14664

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add case study #14664

wants to merge 3 commits into from

Conversation

goulinkh
Copy link
Contributor

@goulinkh goulinkh commented Jan 20, 2025

Done

  • Add new case study

QA

Issue / Card

Fixes WD-18130

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fd144e6). Learn more about missing BASE report.
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14664   +/-   ##
=======================================
  Coverage        ?   72.26%           
=======================================
  Files           ?      120           
  Lines           ?     3404           
  Branches        ?     1174           
=======================================
  Hits            ?     2460           
  Misses          ?      919           
  Partials        ?       25           

@akbarkz akbarkz requested review from eliman11 and kim-isaac January 21, 2025 12:21
@eliman11
Copy link

Thanks @goulinkh! Just a couple of changes:

  • CTA section at the bottom should be: "Contact us about your IoT use case >"
  • Remove alt text from all of the images on the page - I think these might have been duplicated from other pages

@kim-isaac
Copy link

kim-isaac commented Jan 21, 2025

Ty @goulinkh ! From the visual side I have a few comments:

In the logo section:
Could we fix the logo size as per the specifications below?
Screenshot 2025-01-21 at 17 00 52
For reference, the current template is applied like this.

for the quote photo:
Also, considering tablet view, I think it’s better to use the original fixed-size image rather than the one I shared earlier this morning(which includes the right margin).
Screenshot 2025-01-21 at 17 12 25

For the mobile view, would it be possible to switch the layout to Option 1 or Option 2? If Option 1 is not available in the current Vanilla Pattern template, I suggest removing the person’s image entirely for the mobile view.
Screenshot 2025-01-21 at 17 14 03

For a similar example to Option 1, please refer to the link here.

Thank you again :)

@goulinkh
Copy link
Contributor Author

Hello @eliman11 @kim-isaac I've applied the suggested changes let me know if there any remaining issues or if you need to apply further adjustments.

@eliman11
Copy link

Thanks for those changes @goulinkh! Adding UX+1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants