-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add case study #14664
base: main
Are you sure you want to change the base?
Add case study #14664
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14664 +/- ##
=======================================
Coverage ? 72.26%
=======================================
Files ? 120
Lines ? 3404
Branches ? 1174
=======================================
Hits ? 2460
Misses ? 919
Partials ? 25 |
Thanks @goulinkh! Just a couple of changes:
|
Ty @goulinkh ! From the visual side I have a few comments: In the logo section: for the quote photo: For the mobile view, would it be possible to switch the layout to Option 1 or Option 2? If Option 1 is not available in the current Vanilla Pattern template, I suggest removing the person’s image entirely for the mobile view. For a similar example to Option 1, please refer to the link here. Thank you again :) |
Hello @eliman11 @kim-isaac I've applied the suggested changes let me know if there any remaining issues or if you need to apply further adjustments. |
84cd5c0
to
c07e43d
Compare
Thanks for those changes @goulinkh! Adding UX+1 :) |
Done
QA
Issue / Card
Fixes WD-18130
Help
QA steps - Commit guidelines