Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-18199-change-get-ubuntu-to-download-ubuntu-in-the-top-navigation-on-ubuntu-com #14653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhigyanghosh30
Copy link
Contributor

Done

  • Changed Get Ubuntu to Download Ubuntu on the nav

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • The nav item should say Download Ubuntu instead of Get Ubuntu

Issue / Card

Fixes #WD-18199

Screenshots

image

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@jmuzina
Copy link
Member

jmuzina commented Jan 15, 2025

This makes the navbar wrap from about 1212px width to 1250px width, cutting off the search icon slightly and breaking horizontal alignment:

image

I wonder if there is a way to avoid that. @lyubomir-popov any ideas?

@lyubomir-popov
Copy link
Contributor

I wonder if there is a way to avoid that. @lyubomir-popov any ideas?

move the breakpoint where we switch to mobile... not ideal but the only choice if the item has to that long.

@jmuzina
Copy link
Member

jmuzina commented Jan 16, 2025

I wonder if there is a way to avoid that. @lyubomir-popov any ideas?

move the breakpoint where we switch to mobile... not ideal but the only choice if the item has to that long.

Yes, we do have a navigation-specific variable $breakpoint-navigation-threshold that could be adjusted to only apply this breakpoint change for navigation, and not change the mobile breakpoint across the entire site. Overriding that should help.

u.com already overrides that breakpoint; it binds it to $viewport-threshold, which is set to 1212px, lining up with the starting point of the problematic width range noted in my previous message.

$viewport-threshold: 1212px;

If that variable is set higher (perhaps around 1250px), this behavior can be mitigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants