-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-16838 Rebranded /landscape/managed page #14580
base: feature-rebrand-landscape
Are you sure you want to change the base?
WD-16838 Rebranded /landscape/managed page #14580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-landscape #14580 +/- ##
============================================================
Coverage ? 69.64%
============================================================
Files ? 120
Lines ? 3419
Branches ? 1174
============================================================
Hits ? 2381
Misses ? 1013
Partials ? 25 |
Thanks @muhammad-ali-pk ! Only a couple of things from me:
|
Thanks @mattea-turic! All done! |
Thanks @muhammad-ali-pk, this looks great! Just a few quick comments:
|
@eliman11 Thanks Elaine. All done! |
|
@Sophie-32 Thanks Sophie! I have added the suggestion. |
1d6a072
to
42a7ad0
Compare
@muhammad-ali-pk - thanks for flagging. Yes for logos our guidance is to "se the brand name (for example, ‘Microsoft Azure,’ not ‘Microsoft Azure logo’). Use empty state if the company name is used in the title or a link label." |
Done
QA
Issue / Card
Fixes #WD-16838