Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CTA color to positive (green) #14491

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Change CTA color to positive (green) #14491

merged 2 commits into from
Nov 21, 2024

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Nov 21, 2024 •
edited by jira bot
Loading

Done

  • Changed CTA color on the Pro section on the u.c homepage to green (positive)

QA

Issue / Card

Fixes WD-17037

Screenshots

Before
Before
After
After

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petesfrench
Copy link
Contributor

Looking good!

A couple pointers when setting up a PR:

  • add the appropriate 'review needed' labels (in this case code and qa)
  • Include a link to the issue it fixes. For the easier references and so that it will automatically close the jira issue
  • It is also nice to include the demo in the QA steps with the exact path (not so relevant
  • here as it is homepage)

petesfrench
petesfrench approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammad-ali-pk muhammad-ali-pk merged commit f381eb2 into main Nov 21, 2024
29 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the WD-17037 branch November 21, 2024 07:40
petesfrench added a commit that referenced this pull request Nov 21, 2024
@muhammad-ali-pk @petesfrench
Change CTA color to positive (green) (#14491)
a721a8b 
* Change CTA color to positive (green)

* Update templates/base_index.html

Co-authored-by: Peter French <[email protected]>

---------

Co-authored-by: Muhammad Ali <[email protected]>
Co-authored-by: Peter French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petesfrench petesfrench petesfrench approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhammad-ali-pk @webteam-app @petesfrench