Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump cookie-policy to v3.6.4 #13946

Merged
merged 1 commit into from
Jun 12, 2024
Merged

chore: Bump cookie-policy to v3.6.4 #13946

merged 1 commit into from
Jun 12, 2024

Conversation

petesfrench
Copy link
Contributor

Done

  • Bump cookie-policy to v3.6.4

QA

  • Check out
  • Delete cookies so you get the cookie policy pop up
  • Accept nothing and check that in cookies there exists _cookies_accepted=essential
  • Repeat with only accept 'performance', only accepting 'functional' and finally 'all'

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-11997?atlOrigin=eyJpIjoiMjZiZWI5N2FjYzI3NGMyZDg4YjM1ZTM4YzkyZjk3YzkiLCJwIjoiaiJ9

@webteam-app
Copy link

Copy link
Contributor

@carkod carkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would have done this with renovate 👍

@petesfrench
Copy link
Contributor Author

@carkod For some reason the renovate PR didn't open. Is there a way to trigger it manually?

@petesfrench petesfrench merged commit 6756eba into main Jun 12, 2024
26 checks passed
@petesfrench petesfrench deleted the bump-cookie-policy branch June 12, 2024 15:14
@carkod
Copy link
Contributor

carkod commented Jun 13, 2024

@carkod For some reason the renovate PR didn't open. Is there a way to trigger it manually?

I think you have to ask renovate to rebase this one #13687

britneywwc pushed a commit to britneywwc/ubuntu.com that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants