Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials: Convert confidentiality agreement config var to bool before comparison #13602

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jpmartinspt
Copy link
Contributor

@jpmartinspt jpmartinspt commented Feb 21, 2024

Done

Credentials: Convert confidentiality agreement config var to bool before comparison.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/credentials/exam?id=1
  • The page should render
  • Set env var to true
  • Restart the site using the command ./run serve or dotrun
  • The agreement page should show.

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13602.demos.haus

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9058fa) 74.41% compared to head (c4173f1) 74.41%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13602   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         107      107           
  Lines        2838     2838           
  Branches      946      946           
=======================================
  Hits         2112     2112           
  Misses        702      702           
  Partials       24       24           

@jpmartinspt jpmartinspt merged commit 704cf98 into canonical:main Feb 22, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants