Intel NUC rebrand WD-8795 #13580

carkod · 2024-02-14T10:43:28Z

Done

Rebrand Intel NUC page

QA

Check https://ubuntu-com-13580.demos.haus/download/intel-nuc against copy docs content should be almost the same as prod
- Be sure to test on mobile, tablet and desktop screen sizes
[List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-8798

Screenshots

Help

QA steps - Commit guidelines

webteam-app · 2024-02-14T10:43:31Z

Demo starting at https://ubuntu-com-13580.demos.haus

codecov · 2024-02-14T10:45:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c77921) 74.41% compared to head (857c157) 74.41%.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           download-bubble-wd-8482   #13580   +/-   ##
========================================================
  Coverage                    74.41%   74.41%           
========================================================
  Files                          107      107           
  Lines                         2838     2838           
  Branches                       946      946           
========================================================
  Hits                          2112     2112           
  Misses                         702      702           
  Partials                        24       24

juanruitina · 2024-02-16T14:46:41Z

Doesn't have paper background
Across all pages: the numeration in lists inside steps start by 0.
Across all pages: the HR and the text inside steps don't expand to the right margin on phones (heading does), see below. Might have to do something with grid and gaps.

lyubomir-popov · 2024-02-19T16:58:45Z

Much better @carkod ! Thanks for the harsd work.

Final list of small niggles:

Numbers missing here:

This second indent looks strange to me:

Can we please remove the nested list inside the parent divided list, and justr place this copy directly in the parent divided list. With a dot at the end of the previous link (cc @juanruitina):

"This image is certified for the Dawson Canyon NUC models: NUC7i7DNHE, NUC7i7DNKE, NUC7i7DNBE, NUC7i5DNHE, NUC7i5DNKE, NUC7i5DNBE, NUC7i3DNHE, NUC7i3DNKE, and NUC7i3DNBE, and for the June Canyon NUC models: NUC7PJYH and NUC7CJYH"

lyubomir-popov · 2024-02-19T16:54:22Z

templates/download/intel-nuc.html

-    <div class="col-8">
-      <h1>Install Ubuntu Core on the Intel<sup>&reg;</sup> NUC</h1>
-      <p>There are two install options for the Intel NUC: <a href="#core">Ubuntu Core</a> or <a href="intel-nuc-desktop">Ubuntu Desktop</a>  This page is for Ubuntu Core.</p>
+<section class="p-strip is-shallow">


Suggested change

<section class="p-strip is-shallow">

<section class="p-strip is-shallow u-no-padding--bottom">

carkod · 2024-02-19T17:04:09Z

/download/intel-nuc

Yeah, that doesn't have numbers, it's an unorderd nested list.

Or I can remove the hr?

juanruitina · 2024-02-20T08:36:33Z

LGTM!

carkod · 2024-02-20T09:48:46Z

static/js/src/static-forms.js

+
+  // Exclude forms that don't need loader
+  const cancelLoader = submitButton.classList.contains("no-loader");
+
+  if (submitButton && !cancelLoader) {


Needed a way to cancel the loader after download, because unlike other forms we don't navigate to another page, so it keeps rolling the spinner forever.

lyubomir-popov · 2024-02-20T11:22:30Z

@carkod why are steps 2 and 3 misaligned - counters and text are not on the same baseline:

opther than that, the rest looks good, thanks!

mtruj013

LGTM, some questions/changes needed:

mtruj013 · 2024-02-20T15:55:08Z

templates/download/intel-nuc.html

-        </div>
-      </div>
+    <div class="col-6 col-medium-3">
+      <p>There are two install options for the Intel NUC: <a href="/download/intel-nuc">Ubuntu Core</a> or <a href="/download/intel-nuc-desktop">Ubuntu Desktop</a>  This page is for Ubuntu Core.</p>


Is the first link supposed to route to a specific section on this page @juanruitina?

It should link to this current page heading, that's how it is in the prod page, but that heading has been removed for the rebranded page.

mtruj013 · 2024-02-20T15:59:41Z

templates/download/intel-nuc.html

+      <p class="p-heading--5">Minimum requirements</p>
+      <ul class="p-list--divided">
+        <li class="p-list__item is-ticked">An Ubuntu SSO account with an SSH key</li>
+        <li class="p-list__item is-ticked">An Intel NUC with BIOS updated to the latest version (<a href="https://www.intel.com/content/www/us/en/support/articles/000033300/intel-nuc.html">update instructions</a>)</li>


Suggested change

<li class="p-list__item is-ticked">An Intel NUC with BIOS updated to the latest version (<a href="https://www.intel.com/content/www/us/en/support/articles/000033300/intel-nuc.html">update instructions</a>)</li>

<li class="p-list__item is-ticked">An Intel<sup>®</sup> NUC with BIOS updated to the latest version (<a href="https://www.intel.com/content/www/us/en/support/articles/000033300/intel-nuc.html">update instructions</a>)</li>

mtruj013 · 2024-02-20T16:05:20Z

templates/download/intel-nuc.html

      <li class="p-stepped-list__item">
-        <h3 class="p-stepped-list__title">
-
+        <hr class="p-rule u-hide--large" />
+        <h2 class="p-stepped-list__title">
+          Set up an Ubuntu SSO account
+        </h2>
+        <div class="p-stepped-list__content">
+          <p>An Ubuntu SSO account is required to create the first user on an Ubuntu Core installation.</p>
+          <ol class="p-list--divided">
+            <li class="p-list__item">Start by creating an <a href="https://login.ubuntu.com/">Ubuntu SSO account</a>.</li>
+            <li class="p-list__item">Import an SSH Key into your <a href="https://login.ubuntu.com/ssh-keys">Ubuntu SSO account</a>. (<a href="https://help.ubuntu.com/community/SSH/OpenSSH/Keys">instructions</a>)</li>
+          </ol>
+        </div>
+      </li>


I thought we agreed to use existing partials. Why repeat this code if it's word for word exactly the same?

The reason why I pulled it out is because doesn't make much sense to me semantically to have a list as a separate component/partial. Lists should always be with ul or li elements, so we can clearly see the styling and the hierarchy, having them separately just adds more complexity. I'd agree if it were a div or a section or any other independent HTML element.

mtruj013 · 2024-02-20T16:10:43Z

templates/download/intel-nuc.html

-                <li>This image is certified for the Dawson Canyon NUC models: NUC7i7DNHE, NUC7i7DNKE, NUC7i7DNBE, NUC7i5DNHE, NUC7i5DNKE, NUC7i5DNBE, NUC7i3DNHE, NUC7i3DNKE, and NUC7i3DNBE, and for the June Canyon NUC models: NUC7PJYH and NUC7CJYH</li>
-              </ul>
+            <li class="p-list__item">
+              Or download the <a href="https://people.canonical.com/~platform/images/nuc/intel_dawson/dawson-uc18-m7-20190122-10.img.xz">Ubuntu Core 18 image for Intel Dawson Canyon and June Canyon NUC</a>.This image is certified for the Dawson Canyon NUC models: NUC7i7DNHE, NUC7i7DNKE, NUC7i7DNBE, NUC7i5DNHE, NUC7i5DNKE, NUC7i5DNBE, NUC7i3DNHE, NUC7i3DNKE, and NUC7i3DNBE, and for the June Canyon NUC models: NUC7PJYH and NUC7CJYH


Suggested change

Or download the <a href="https://people.canonical.com/~platform/images/nuc/intel_dawson/dawson-uc18-m7-20190122-10.img.xz">Ubuntu Core 18 image for Intel Dawson Canyon and June Canyon NUC</a>.This image is certified for the Dawson Canyon NUC models: NUC7i7DNHE, NUC7i7DNKE, NUC7i7DNBE, NUC7i5DNHE, NUC7i5DNKE, NUC7i5DNBE, NUC7i3DNHE, NUC7i3DNKE, and NUC7i3DNBE, and for the June Canyon NUC models: NUC7PJYH and NUC7CJYH

Or download the <a href="https://people.canonical.com/~platform/images/nuc/intel_dawson/dawson-uc18-m7-20190122-10.img.xz">Ubuntu Core 18 image for Intel Dawson Canyon and June Canyon NUC</a>. This image is certified for the Dawson Canyon NUC models: NUC7i7DNHE, NUC7i7DNKE, NUC7i7DNBE, NUC7i5DNHE, NUC7i5DNKE, NUC7i5DNBE, NUC7i3DNHE, NUC7i3DNKE, and NUC7i3DNBE, and for the June Canyon NUC models: NUC7PJYH and NUC7CJYH

mtruj013 · 2024-02-20T16:28:06Z

templates/download/intel-nuc.html

+      <li class="p-stepped-list__item">
+        <hr class="p-rule u-hide--large" />
+        <h2 class="p-stepped-list__title">
+          First boot setup
+        </h2>
        <div class="p-stepped-list__content">
-          <ol class="u-no-margin--left">
-            <li>Start the NUC and push F10 to enter the boot menu.</li>
-            <li>Select the USB flash drive as a boot option.</li>
-            <li>Select "Try Ubuntu without installing".</li>
+          <ol class="p-list--divided u-no-margin--left">
+            <li class="p-list__item">The system will boot then become ready to configure.</li>
+            <li class="p-list__item">The device will display the prompt "Press enter to configure".</li>
+            <li class="p-list__item">Press enter then select "Start" to begin configuring your network and an administrator account. Follow the instructions on the screen, you will be asked to configure your network and enter your Ubuntu SSO credentials.</li>
+            <li class="p-list__item">
+              <p>At the end of the process, you will see your credentials to access your Ubuntu Core machine:</p>
+              <pre><code>This device is registered to &lt;Ubuntu SSO email address&gt;.
+      Remote access was enabled via authentication with the SSO user &lt;Ubuntu SSO user name&gt;
+      Public SSH keys were added to the device for remote access.</code></pre>
+            </li>
          </ol>
        </div>
      </li>


Same thing here, there's a partial for this already with exactly the same code /download/shared/_first-boot-setup.html

carkod marked this pull request as draft February 14, 2024 10:44

carkod force-pushed the intel-nuc-wd-8795 branch 2 times, most recently from e5bd041 to 42b5af2 Compare February 14, 2024 11:00

carkod changed the title ~~Intel nuc wd 8795~~ Intel NUC rebrand WD-8795 Feb 15, 2024

carkod added Review: Design needed Review: UX needed labels Feb 15, 2024

carkod changed the base branch from main to download-bubble-wd-8482 February 15, 2024 11:00

carkod force-pushed the intel-nuc-wd-8795 branch 5 times, most recently from 59c606e to 606c11e Compare February 15, 2024 18:17

carkod marked this pull request as ready for review February 15, 2024 18:17

juanruitina added Review: UX -1 and removed Review: UX needed labels Feb 16, 2024

akbarkz force-pushed the download-bubble-wd-8482 branch from bb29c5d to aec830f Compare February 19, 2024 09:46

carkod force-pushed the intel-nuc-wd-8795 branch 8 times, most recently from 94d6c02 to b1a152b Compare February 19, 2024 16:57

lyubomir-popov reviewed Feb 19, 2024

View reviewed changes

carkod unassigned juanruitina Feb 20, 2024

carkod added Review: QA needed Review: Code needed labels Feb 20, 2024

carkod commented Feb 20, 2024

View reviewed changes

lyubomir-popov added Review: Design +1 and removed Review: Design needed labels Feb 20, 2024

carkod assigned mtruj013 and unassigned lyubomir-popov Feb 20, 2024

mtruj013 approved these changes Feb 20, 2024

View reviewed changes

mtruj013 added Review: QA +1 Review: Code +1 (with changes) and removed Review: QA needed Review: Code needed labels Feb 20, 2024

Rebranding of Intel NUC page

857c157

carkod force-pushed the intel-nuc-wd-8795 branch from 6c204cc to 857c157 Compare February 20, 2024 18:44

carkod merged commit a8770e6 into canonical:download-bubble-wd-8482 Feb 20, 2024
14 of 15 checks passed

carkod deleted the intel-nuc-wd-8795 branch February 20, 2024 18:49

carkod added a commit that referenced this pull request Feb 20, 2024

Rebranding of Intel NUC page (#13580)

2649978

akbarkz pushed a commit that referenced this pull request Feb 21, 2024

Rebranding of Intel NUC page (#13580)

b47929a

akbarkz pushed a commit that referenced this pull request Feb 23, 2024

Rebranding of Intel NUC page (#13580)

1aba79b

akbarkz pushed a commit that referenced this pull request Feb 27, 2024

Rebranding of Intel NUC page (#13580)

0c73190

akbarkz pushed a commit that referenced this pull request Mar 4, 2024

Rebranding of Intel NUC page (#13580)

b536727

carkod added a commit to carkod/ubuntu.com that referenced this pull request Mar 11, 2024

Rebranding of Intel NUC page (canonical#13580)

3a8f56d

akbarkz pushed a commit that referenced this pull request Mar 12, 2024

Rebranding of Intel NUC page (#13580)

631f1c1

akbarkz pushed a commit that referenced this pull request Mar 20, 2024

Rebranding of Intel NUC page (#13580)

5832e65

akbarkz pushed a commit that referenced this pull request Apr 1, 2024

Rebranding of Intel NUC page (#13580)

7a43bab

akbarkz pushed a commit that referenced this pull request Apr 8, 2024

Rebranding of Intel NUC page (#13580)

e1bf64b

mtruj013 pushed a commit to mtruj013/ubuntu.com that referenced this pull request Apr 8, 2024

Rebranding of Intel NUC page (canonical#13580)

3b5144b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Intel NUC rebrand WD-8795 #13580

Intel NUC rebrand WD-8795 #13580

carkod commented Feb 14, 2024 •

edited by mtruj013

Loading

webteam-app commented Feb 14, 2024

codecov bot commented Feb 14, 2024 •

edited

Loading

juanruitina commented Feb 16, 2024 •

edited by carkod

Loading

lyubomir-popov commented Feb 19, 2024

lyubomir-popov Feb 19, 2024

carkod commented Feb 19, 2024 •

edited

Loading

juanruitina commented Feb 20, 2024

carkod Feb 20, 2024

lyubomir-popov commented Feb 20, 2024 •

edited

Loading

mtruj013 left a comment

mtruj013 Feb 20, 2024

carkod Feb 20, 2024 •

edited

Loading

mtruj013 Feb 20, 2024

mtruj013 Feb 20, 2024

carkod Feb 20, 2024

mtruj013 Feb 20, 2024

mtruj013 Feb 20, 2024

	<section class="p-strip is-shallow">
	<section class="p-strip is-shallow u-no-padding--bottom">

	<li class="p-list__item is-ticked">An Intel NUC with BIOS updated to the latest version (<a href="https://www.intel.com/content/www/us/en/support/articles/000033300/intel-nuc.html">update instructions</a>)</li>
	<li class="p-list__item is-ticked">An Intel<sup>®</sup> NUC with BIOS updated to the latest version (<a href="https://www.intel.com/content/www/us/en/support/articles/000033300/intel-nuc.html">update instructions</a>)</li>

Intel NUC rebrand WD-8795 #13580

Intel NUC rebrand WD-8795 #13580

Conversation

carkod commented Feb 14, 2024 • edited by mtruj013 Loading

Done

QA

Issue / Card

Screenshots

Help

webteam-app commented Feb 14, 2024

codecov bot commented Feb 14, 2024 • edited Loading

Codecov Report

juanruitina commented Feb 16, 2024 • edited by carkod Loading

lyubomir-popov commented Feb 19, 2024

Choose a reason for hiding this comment

carkod commented Feb 19, 2024 • edited Loading

juanruitina commented Feb 20, 2024

Choose a reason for hiding this comment

lyubomir-popov commented Feb 20, 2024 • edited Loading

mtruj013 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carkod Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carkod commented Feb 14, 2024 •

edited by mtruj013

Loading

codecov bot commented Feb 14, 2024 •

edited

Loading

juanruitina commented Feb 16, 2024 •

edited by carkod

Loading

carkod commented Feb 19, 2024 •

edited

Loading

lyubomir-popov commented Feb 20, 2024 •

edited

Loading

carkod Feb 20, 2024 •

edited

Loading