Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to vanilla-4.7.0 #13548

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Bump to vanilla-4.7.0 #13548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a93e907
Bump to vanilla-4.7.0
petesfrench Feb 7, 2024
1ff5d68
Revert navigation padding
petesfrench Feb 8, 2024
8129e0b
Update global-nav padding to align with content
petesfrench Feb 8, 2024
d372cd8
Add p-navigation__row--25-75
petesfrench Feb 9, 2024
a258404
Make css adjustments to fit new vainlla pattern
petesfrench Feb 12, 2024
7c88ede
Apply changes from cpde review
petesfrench Feb 14, 2024
53dfc5d
Re-align secondary nav
petesfrench Feb 16, 2024
b9dbac5
Make top nav align right
petesfrench Feb 20, 2024
7e45591
Decrease breakpoint-threshold
petesfrench Feb 20, 2024
47bdb30
Format SCSS
petesfrench Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"typescript": "4.5.4",
"url-polyfill": "1.1.12",
"url-search-params-polyfill": "8.1.1",
"vanilla-framework": "4.5.1",
"vanilla-framework": "4.7.0",
"yup": "0.32.11"
},
"resolutions": {
Expand Down
14 changes: 0 additions & 14 deletions static/sass/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,20 +1366,6 @@ $color-link-dark: #69c !default;
}
}

// XXX: @bartaz: this will be covered in Vanilla
// can be removed once https://github.com/canonical/vanilla-framework/issues/4875 is done and released
.p-logo-section.has-misaligned-images {
Copy link
Contributor

@mtruj013 mtruj013 Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished qa'ing all the pages that use this, but it looks like the logo sections in https://ubuntu-com-13548.demos.haus/financial-services still look buggy without it compare to prod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this seems to just remove the comment, but not actual code. Is this intended?

.p-logo-section__item {
margin-bottom: $spv--x-large;
}

.p-logo-section__logo {
max-height: 5rem;
// make sure image aspect ratio is kept
object-fit: contain;
}
}

// XXX: pete f: vanilla issue here -
// https://github.com/canonical/vanilla-framework/issues/4877
.p-divider {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8568,10 +8568,10 @@ [email protected]:
resolved "https://registry.yarnpkg.com/vanilla-framework/-/vanilla-framework-4.0.0.tgz#a2fee9bd9763ebd6932b764f9d66484dc177d4cc"
integrity sha512-fiPnmaTUe15l5MRNJ6IsiJ8qiunfmgtLETOFltaYiE/bQKL7xTI+riBak2iygBKeF1y0Gi/GxUNt4hyb6xDPKA==

vanilla-framework@4.5.1:
version "4.5.1"
resolved "https://registry.yarnpkg.com/vanilla-framework/-/vanilla-framework-4.5.1.tgz#19b55dd4771c304b2bae8af646312916f5f45917"
integrity sha512-vF7GGZsXcQZnM2522Q2am08to/iM2K+EhsfYPuYsiHvp2kRGxY/rJ8tcjbKftNY859qOqT8yJg0PE+sVmKI5zg==
vanilla-framework@4.7.0:
version "4.7.0"
resolved "https://registry.yarnpkg.com/vanilla-framework/-/vanilla-framework-4.7.0.tgz#93934d1df3b99b4d58f96d5dbc8f47c32ae660c2"
integrity sha512-jhckCsy/e+nZI1qh5ZVH2bj3YZqpYLxnhovo8W/JgzhjQ2LMDI1L1vaw8pjMLt9G4sZqHB/S7KybGQgbIp9phQ==

verbalize@^0.1.2:
version "0.1.2"
Expand Down
Loading