Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-6779] enable 23.10 desktop download button/link #13249

Merged

Conversation

akbarkz
Copy link
Contributor

@akbarkz akbarkz commented Oct 16, 2023

Done

  • Enabled (returned) 23.10 desktop image download button/link on two pages:
    - /download/desktop
    - /download/alternative-downloads
  • Added new property called desktop_version in releases.yml since the latest Desktop image has a different version than all other 23.10 release images
  • Updated the checksum for the latest desktop image

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Navigage to /download/desktop and check that the Download 23.10 button is enabled and the desktop image can be downloaded.
  • Navigate to /download/alternative-downloads and check that Download 23.10 Desktop (64-bit) link exists and clicking on it downloads the desktop image.

Issue / Card

Closes https://warthogs.atlassian.net/browse/WD-6779

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13249.demos.haus

releases.yaml Outdated
Comment on lines 5 to 6
full_version: "23.10"
desktop_version: "23.10.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a point release we should just update the full version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lukasz said this version upgrade applies only to Desktop image. All other images remain 23.10.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #13249 (90d4236) into main (e463af9) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head 90d4236 differs from pull request most recent head 0015be9. Consider uploading reports for the commit 0015be9 to get more accurate results

@@           Coverage Diff           @@
##             main   #13249   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files         106      106           
  Lines        2840     2840           
  Branches      929      929           
=======================================
  Hits         2139     2139           
  Misses        679      679           
  Partials       22       22           

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 with the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants