Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form custom fields #13248

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix form custom fields #13248

merged 1 commit into from
Oct 16, 2023

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Oct 16, 2023

Done

  • Fix custom fields not being passed through on submission

QA

  • View the site locally in your web browser at: https://ubuntu-com-13248.demos.haus/landscape/pricing
  • Click on "Get Landscape SaaS" CTA
  • Fill out and submit the form with the network tab on dev tools open
  • See that the checkbox answers are included in the "Comments_from_lead_c" field

Issue / Card

Fixes #13187 , https://warthogs.atlassian.net/browse/WD-6566

Screenshots

image

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13248.demos.haus

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #13248 (e463af9) into main (c2736db) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13248   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files         106      106           
  Lines        2840     2840           
  Branches      929      929           
=======================================
  Hits         2139     2139           
  Misses        679      679           
  Partials       22       22           

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtruj013 mtruj013 merged commit 30372de into canonical:main Oct 16, 2023
14 of 16 checks passed
@mtruj013 mtruj013 deleted the landscape-form branch October 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payload of one of the /landscape/pricing contact forms doesn't contain user selection.
3 participants