Fix links and fix menu padding (#13355)

* Remove comment * Update nojs-nav links * Format-python
canonical · Nov 28, 2023 · fd61bcb · fd61bcb
1 parent a80daa9
commit fd61bcb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/static/sass/_global-settings.scss b/static/sass/_global-settings.scss
@@ -13,7 +13,6 @@ $color-mid-x-light: #e5e5e5;
 $font-use-subset-latin: true;
 $font-allow-cyrillic-greek-latin: true;
 $font-display-option: fallback;
-$breakpoint-navigation-threshold: 1250px;
-$threshold-6-12-col: $breakpoint-navigation-threshold;
+$breakpoint-navigation-threshold: $viewport-threshold;
 $theme-default-nav: dark;
 $grid-max-width: 80rem;
diff --git a/static/sass/_pattern_navigation.scss b/static/sass/_pattern_navigation.scss
@@ -146,6 +146,10 @@ $meganav-height: 3rem;
     }
 
     @media (max-width: $breakpoint-navigation-threshold) {
+      .row {
+        display: unset;
+      }
+
       .p-navigation__nav {
         margin-left: 0;
         overflow-y: auto;
@@ -413,7 +417,6 @@ $meganav-height: 3rem;
     .p-navigation__item {
       .p-navigation__link {
         color: $color-mid-light;
-        padding: 0.5rem 2rem 0.5rem 0;
       }
     }
 
@@ -579,6 +582,7 @@ $meganav-height: 3rem;
       }
 
       .row {
+        display: unset;
         padding-left: 0;
         padding-right: 0;
       }

diff --git a/templates/templates/meganav/base.html b/templates/templates/meganav/base.html
@@ -245,7 +245,7 @@
             <ul class="p-list">
               {% for link in links_section.links %}
                 <li class="p-list__item">
-                  <a href="{{ link.url }}">{{ link.title }}</a>
+                  <a class="dropdown-window__side-panel-link" href="{{ link.url }}">{{ link.title }}</a>
                 </li>
               {% endfor %}
             </ul>

diff --git a/templates/templates/meganav/navigation-nojs.html b/templates/templates/meganav/navigation-nojs.html
@@ -103,7 +103,7 @@ <h3 class="p-heading--2 u-no-padding--left">{{side_nav_section.title}}</h3>
                     <ul class="p-list">
                       {% for link in links_section.links %}
                         <li class="p-list__item">
-                          <a href="{{ link.url }}">{{ link.title }}</a>
+                          <a class="dropdown-window__side-panel-link" href="{{ link.url }}">{{ link.title }}</a>
                         </li>
                       {% endfor %}
                     </ul>
@@ -190,7 +190,7 @@ <h3 class="p-heading--2 u-no-padding--left">{{side_nav_section.title}}</h3>
                 <ul class="p-list">
                   {% for link in links_section.links %}
                     <li class="p-list__item">
-                      <a href="{{ link.url }}">{{ link.title }}</a>
+                      <a class="dropdown-window__side-panel-link" href="{{ link.url }}">{{ link.title }}</a>
                     </li>
                   {% endfor %}
                 </ul>

diff --git a/webapp/app.py b/webapp/app.py
@@ -140,7 +140,6 @@
     subscription_centre,
     thank_you,
     unlisted_engage_page,
-    build_engage_pages_sitemap,
     navigation_nojs,
 )