Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with ops 2.10 #287

Merged
merged 4 commits into from
Feb 6, 2024
Merged

compat with ops 2.10 #287

merged 4 commits into from
Feb 6, 2024

Conversation

PietroPasotti
Copy link
Contributor

Issue

Fixes #285

Solution

Rely on ops 2.10 behaviour that breaking relations don't show up in model.relations.

Testing Instructions

Unit/integration tests should do it.

Release Notes

Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Much simpler than I anticipated.

lib/charms/traefik_k8s/v1/ingress_per_unit.py Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit 40ec7c8 into main Feb 6, 2024
13 checks passed
@PietroPasotti PietroPasotti deleted the ipu-relation-broken-fix branch February 6, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IPU] _handle_relation is incorrectly relying on relation-broken
3 participants