Add initial sentry configuration for API #44
Conversation
|
|
||
| SENTRY_DSN = os.getenv("SENTRY_DSN") | ||
| if SENTRY_DSN: | ||
| sentry_sdk.init(SENTRY_DSN) # type: ignore |
There was a problem hiding this comment.
Just in case, I had to tell mypy to ignore Cannot instantiate abstract class "init" with abstract attribute "__exit__" [abstract] error while initialising sentry client. It's a known bug that was fixed in later versions. But since our self-hosted Sentry instance doesn't support latest clients that include this bug fix, we have to go with this approach.
|
I'm assuming this resolves the backend part and the frontend is coming in a separate PR? |
Since API and frontend should be tracked separately on sentry (because they use different sentry clients), I've decided to create a PR for API first. I'll create a separate PR for the frontend |
There was a problem hiding this comment.
After discussing this a bit more on MM, I think it would be easiest to just do this for now, since it wouldn't require setting these DSNs in the environment. I still think that it would be nice to have this as a configurable option in the future, but we could easily change that after we get the ability to deploy all of this in a more modular way. So +1
This PR resolves https://warthogs.atlassian.net/browse/RTW-133 and adds support for Sentry in TO API.
Here is the project for TO API on sentry: https://sentry.is.canonical.com/canonical/test-observer-api/
The changes were done according to this doc since Sentry doesn't support FastAPI specifically: https://sentry.is.canonical.com/canonical/test-observer-api/getting-started/python/
Also, I've updated the link for docker in README since installing it as snap causes issues when it's running with LXD, and we use LXD local development env with our other projects.
UPD: I've also create TO staging API project in sentry: https://sentry.is.canonical.com/canonical/test-observer-api-staging/