Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

S3 support and scaled monolith #127

Merged
merged 27 commits into from
Jun 13, 2024
Merged

S3 support and scaled monolith #127

merged 27 commits into from
Jun 13, 2024

Conversation

mmkay
Copy link
Contributor

@mmkay mmkay commented Jun 8, 2024

Issue

Add s3 support to tempo charm and scaled monolithic setup in case application is scaled to more than 1 unit. Closes #62, #119

Solution

Add s3 interface that can be used by s3-integrator.

Context

Even though mimir_config is already using types, I haven't switched to typing yet as I expect we'll have more changes with tempo_cluster soon.

Testing Instructions

In theory the following bundle should work, but it still requires manual steps. Follow the steps added in HACKING.md to deploy minio alongside:

bundle: kubernetes
applications:
  minio:
    charm: minio
    channel: latest/edge
    revision: 316
    base: [email protected]/stable
    resources:
      oci-image: 543
    scale: 1
    options:
      access-key: minio-access-key
      secret-key: minio-secret
    constraints: arch=amd64
    storage:
      minio-data: kubernetes,1,10240M
    trust: true
  s3-integrator:
    charm: s3-integrator
    channel: latest/stable
    revision: 17
    scale: 1
    options:
      bucket: tempo
    constraints: arch=amd64
  tempo:
    charm: local:tempo-k8s-1
    scale: 1
    constraints: arch=amd64
    storage:
      data: kubernetes,1,1024M
relations:
- - tempo:s3
  - s3-integrator:s3-credentials

Release Notes

@mmkay mmkay marked this pull request as ready for review June 8, 2024 20:54
src/tempo.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
HACKING.md Show resolved Hide resolved
@mmkay mmkay requested a review from IbraAoad June 12, 2024 13:19
@PietroPasotti
Copy link
Contributor

YESSSS

@mmkay
Copy link
Contributor Author

mmkay commented Jun 12, 2024

two more things still pending from manual tests, not merging yet

Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
note to self: next time, let's keep the formatting changes aside :/

This was referenced Jun 13, 2024
Copy link

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random fly-by review

tests/manual/facades/s3.yaml Show resolved Hide resolved
tests/scenario/test_charm.py Outdated Show resolved Hide resolved
lib/charms/data_platform_libs/v0/s3.py Show resolved Hide resolved
@mmkay mmkay changed the title S3 support S3 support and scaled monolith Jun 13, 2024
@mmkay mmkay merged commit d55241f into main Jun 13, 2024
13 checks passed
@mmkay mmkay deleted the s3-support branch June 13, 2024 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for object storage
4 participants