This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmkay
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
PietroPasotti,
sed-i and
simskij
as code owners
June 8, 2024 20:54
IbraAoad
suggested changes
Jun 10, 2024
YESSSS |
two more things still pending from manual tests, not merging yet |
PietroPasotti
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
note to self: next time, let's keep the formatting changes aside :/
dimaqq
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random fly-by review
IbraAoad
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add s3 support to tempo charm and scaled monolithic setup in case application is scaled to more than 1 unit. Closes #62, #119
Solution
Add
s3
interface that can be used by s3-integrator.Context
Even though mimir_config is already using types, I haven't switched to typing yet as I expect we'll have more changes with tempo_cluster soon.
Testing Instructions
In theory the following bundle should work, but it still requires manual steps. Follow the steps added in HACKING.md to deploy minio alongside:
Release Notes