Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

fix for #120 #122

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix for #120 #122

merged 1 commit into from
Jun 6, 2024

Conversation

PietroPasotti
Copy link
Contributor

Issue

Fixes #120

Solution

Try both

Release Notes

  • fixed issue in charm tracing lib that would incorrectly wrap staticmethods depending on how they're called

@PietroPasotti PietroPasotti merged commit cbd655c into main Jun 6, 2024
13 checks passed
@PietroPasotti PietroPasotti deleted the fix-staticmethod-tracing branch June 6, 2024 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmkay mmkay mmkay approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@dstathis dstathis Awaiting requested review from dstathis

@IbraAoad IbraAoad Awaiting requested review from IbraAoad

@lucabello lucabello Awaiting requested review from lucabello

@sed-i sed-i Awaiting requested review from sed-i

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

charm_tracing charmlib does not correctly wrap staticmethods in instrumented code
2 participants
@PietroPasotti @mmkay