Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing test vsock in checkbox provider #249

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hector-cao
Copy link
Collaborator

vsock test uses a customized iperf tool with vsock support
this tool is installed on the host

however, checkbox24 comes with iperf tool and it will be used by the test,
without vsock support, the test fails

we device to bundle the customized iperf tool to the checkbox provider
and set PATH variable to use the iperf in the provider

one other solution would be to set the PATH to use the iperf installed on the system
but we think that bundle iperf3 into the provider is a better approach

checkbox22/24 comes with the iperf3 package
it will mask the iperf-vsock tool we install on the host
this tool should be bundled in the snap
@hector-cao hector-cao force-pushed the noble-24.04-fix-failing-test-iperf branch from 47f0fa0 to 88488e0 Compare October 20, 2024 21:32
@hector-cao hector-cao requested a review from a team October 20, 2024 21:33
Copy link
Contributor

@mckees mckees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mckees mckees merged commit 6c45975 into noble-24.04 Oct 21, 2024
2 checks passed
@mckees mckees deleted the noble-24.04-fix-failing-test-iperf branch October 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants