Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests cause of permanent modification of qemu machine arguments #245

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

hector-cao
Copy link
Collaborator

currently in the test tests/test_quote_configfs_tsm.py::test_qgs_socket we modify permanently the qemu -machine and -object arguments. this can make following tests fail

we do not want to modify these arguments permanently but only for the current test

…ect arguments

currently in the test tests/test_quote_configfs_tsm.py::test_qgs_socket
we modify permanently the qemu -machine and -object arguments.
this can make following tests fail

we do not want to modify these arguments permanently but only for
the current test
@hector-cao hector-cao requested a review from a team October 10, 2024 10:17
@mckees
Copy link
Contributor

mckees commented Oct 10, 2024

I'm seeing that this is a more precise way to enable the needed socket, but where does this end up getting changed back? Or are you just altering a temporary state that gets destroyed when the test gets cleaned up?

@hector-cao
Copy link
Collaborator Author

I'm seeing that this is a more precise way to enable the needed socket, but where does this end up getting changed back? Or are you just altering a temporary state that gets destroyed when the test gets cleaned up?

Yes, this change is done in the context of the qm object (passed as argument here :

def test_qgs_socket(qm):
), this object will be destroyed when we exit the test function (test_qgs_socket). With the old source code, the change still persists after the destruction of the object qm

Copy link
Contributor

@mckees mckees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, LGTM then

@hector-cao hector-cao merged commit 8bbe3c6 into noble-24.04 Oct 10, 2024
2 checks passed
@hector-cao hector-cao deleted the noble-24.04-fix-test_quote_configfs_tsm branch October 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants