Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes files now provided in canonical-sphinx==0.3.0 #318

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

SecondSkoll
Copy link
Collaborator

  • Removes superfluous files, adding a custom CSS placeholder
  • Changes source of required package
  • moves gitignore file to root, and changes referenced files and directories to support nested paths

Copy link
Contributor

@tang-mm tang-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but apparently some Sphinx internal dependencies (pillow/ wheel) caused the build failure. Could you verify whether any upstream change is involved?

@SecondSkoll
Copy link
Collaborator Author

SecondSkoll commented Jan 6, 2025

The changes look good to me, but apparently some Sphinx internal dependencies (pillow/ wheel) caused the build failure. Could you verify whether any upstream change is involved?

Looks like it might need an updated version of Python to build...
Pillow for Python 3.12 builds with Python 3.12.8, and the default Ubuntu latest image used as the runner base uses 3.12.3. I'm not entirely sure though, so I'll have to have a tinker.

Edit: This was not correct, but was easy to check at least.

@SecondSkoll
Copy link
Collaborator Author

It appears to be an issue with 24.04 runners not having some of the prerequisites for building Pillow from source. I've added the required packages.

Copy link
Contributor

@tang-mm tang-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SecondSkoll SecondSkoll merged commit 8bef847 into canonical:main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants