-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removes files now provided in canonical-sphinx==0.3.0 #318
Conversation
SecondSkoll
commented
Jan 6, 2025
- Removes superfluous files, adding a custom CSS placeholder
- Changes source of required package
- moves gitignore file to root, and changes referenced files and directories to support nested paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but apparently some Sphinx internal dependencies (pillow
/ wheel
) caused the build failure. Could you verify whether any upstream change is involved?
Looks like it might need an updated version of Python to build... Edit: This was not correct, but was easy to check at least. |
It appears to be an issue with 24.04 runners not having some of the prerequisites for building Pillow from source. I've added the required packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀