Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add support for ubuntu plucky #14716

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sergiocazzolato
Copy link
Collaborator

@sergiocazzolato sergiocazzolato commented Nov 12, 2024

This branch adds support for ubuntu plucky.
Also moves oracular to no-lts

Related: SNAPDENG-34223

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (96ea7b0) to head (9a9ed0a).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14716      +/-   ##
==========================================
+ Coverage   78.95%   79.01%   +0.06%     
==========================================
  Files        1084     1085       +1     
  Lines      146638   147474     +836     
==========================================
+ Hits       115773   116524     +751     
- Misses      23667    23721      +54     
- Partials     7198     7229      +31     
Flag Coverage Δ
unittests 79.01% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maykathm maykathm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@bboozzoo
Copy link
Contributor

+ lxd.lxc launch --quiet ubuntu:25.04 my-ubuntu
Error: Failed instance creation: Failed getting remote image info: Failed getting image: The requested image couldn't be found for fingerprint "25.04"

lxd tests need an update

@bboozzoo
Copy link
Contributor

bboozzoo commented Nov 13, 2024

 + echo 'No driver is available, expecting: skip["ubuntu-25.04-64/515"]="no-driver"'
No driver is available, expecting: skip["ubuntu-25.04-64/515"]="no-driver"
/bin/bash: line 151: skip[$combi_key]: unbound variable
-----
.
2024-11-12 16:31:37 Debug output for google:ubuntu-25.04-64:tests/main/nvidia-files:515

and we need to regenerate data for nvidia files test

edit: will likely need an update of nightly tests as well

This branch adds support for ubuntu plucky. Also moves oracular to
no-lts
@ernestl
Copy link
Collaborator

ernestl commented Nov 19, 2024

Getting basic 25.04 coverage is priority since we need it for upcoming release 2.67.
Please consider merging this even with some understood issues remaining e.g. LXD and nvidia. @sergiocazzolato @bboozzoo

@ernestl ernestl added this to the 2.67 milestone Nov 19, 2024
@ernestl ernestl self-requested a review November 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants