tests: udpate the github workflow to run tests suggested by spread-filter tool #14519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does that also include added? |
zyga
reviewed
Sep 19, 2024
|
@pedronis, yes, any change "add/update" is considered Already updated the description. |
sergiocazzolato
force-pushed
the
tests-run-targeted-tests
branch
from
f943a99
to
0c7c09b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14519 +/- ##
==========================================
+ Coverage 78.95% 79.02% +0.07%
==========================================
Files 1084 1087 +3
Lines 146638 147628 +990
==========================================
+ Hits 115773 116667 +894
- Misses 23667 23731 +64
- Partials 7198 7230 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sergiocazzolato
requested review from
maykathm and
pedronis
and removed request for
pedronis
zyga
approved these changes
Nov 12, 2024
…lter tool Through this change we will run the tests suggested by the spread-filter tool following the rules located in tests/lib/spread/rules which defined for each system. For nested tests, this ruleset will make sure that: . Always that the nested.sh lib or the assertions dir are updated, all the nested test are executed . When an specific nested test is updated, then this is executed . If the "Run Nested" label is added to the PR, all the nested tests will be executed as well. . In master branch, all nested test are executed . In other scenarios, nested tests are not executed. Also, in master branch, all the tests are executed (the tests defined in the matrix for each system).
sergiocazzolato
force-pushed
the
tests-run-targeted-tests
branch
from
0c7c09b
to
ddffbe7
Compare
sergiocazzolato
force-pushed
the
tests-run-targeted-tests
branch
from
bd081cf
to
df1bda6
Compare
This produced issues for example running all the nested tests when it is not needed.
sespiros
added a commit
to sespiros/snapd
that referenced
this pull request
Nov 19, 2024
* master: (44 commits) wrappers: do not reload activation units (canonical#14724) gadget/install: support for no{exec,dev,suid} mount flags interfaces/builtin/mount_control: add support for nfs mounts (canonical#14694) tests: use gojq - part 1 (canonical#14686) interfaces/desktop-legacy: allow DBus access to com.canonical.dbusmenu interfaces/builtin/fwupd.go: allow access to nvmem for thunderbolt plugin tests: removing uc16 executions (canonical#14575) tests: Added arm github runner to build snapd (canonical#14504) tests: no need to run spread when there are not tests matching the filter (canonical#14728) tests/lib/tools/store-state: exit on errors, update relevant tests (canonical#14725) tests: udpate the github workflow to run tests suggested by spread-filter tool (canonical#14519) testtime: add mockable timers for use in tests (canonical#14672) interface/screen_inhibit_control: Improve screen inhibit control for use on core (canonical#14134) tests: use images with 20G disk in openstack (canonical#14720) i/builtin: allow @ in custom-device filepaths (canonical#14651) tests: refactor test-snapd-desktop-layout-with-content tests: fix broken app definition tests: capitalize sentences in comments tests: wrap very long shell line tests: fix raciness in async startup and sync install ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through this change we will run the tests suggested by the spread-filter tool following the rules located in tests/lib/spread/rules which defined for each system.
For nested tests, this ruleset will make sure that: . Always that the nested.sh lib or the assertions dir are updated, all the nested test are executed
. When an specific nested test is added/updated, then this is executed
. If the "Run Nested" label is added to the PR, all the nested tests will be executed as well.
. In master branch, all nested test are executed
. In other scenarios, nested tests are not executed.
Also, in master branch, all the tests are executed (the tests defined in the matrix for each system).