Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: make ucrednetGet() return a *ucrednet structure #10126

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

jhenstridge
Copy link
Contributor

This PR extracts the ucrednet cleanup from PR #9043 into its own pull request. It updates the ucrednetGet helper to return a ucrednet struct rather than return the three credentials separately.

Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, couple small comments

daemon/api_snapctl_test.go Outdated Show resolved Hide resolved
daemon/api_snapctl_test.go Outdated Show resolved Hide resolved
daemon/daemon.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboozzoo bboozzoo merged commit 7ac79ad into canonical:master Apr 12, 2021
benhoyt pushed a commit to canonical/pebble that referenced this pull request Feb 14, 2024
This ports canonical/snapd#10126 from snapd,
so that ucrednetGet() has the same return type.

This change is in preparation for porting the accessChecker API
from snapd (canonical/snapd#10127):
#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants