feat(linter): show missing libraries corresponding package #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syu-w
force-pushed
the
work/CRAFT-2120-missing-library-package
branch
4 times, most recently
from
997881f
to
3ed2dc1
Compare
syu-w
force-pushed
the
work/CRAFT-2120-missing-library-package
branch
from
3ed2dc1
to
bac2a0d
Compare
4 tasks
sergiusens
reviewed
Oct 31, 2023
| @@ -2,6 +2,6 @@ Running linters... | |||
| Running linter: classic | |||
| Running linter: library | |||
| Lint warnings: | |||
| - library: linter-test: missing dependency 'libcaca.so.0'. (https://snapcraft.io/docs/linters-library) | |||
| - library: linter-test: missing dependency 'libslang.so.2'. (https://snapcraft.io/docs/linters-library) | |||
| - library: linter-test: missing dependency 'libcaca.so.0'. (provided by 'libcaca0') (https://snapcraft.io/docs/linters-library) | |||
There was a problem hiding this comment.
i am not sure it will be easy to correlate provided by with a possible stage-packages entry. Should be fine if the documentation mentions that.
sergiusens
approved these changes
Oct 31, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4430 +/- ##
==========================================
- Coverage 89.20% 89.18% -0.03%
==========================================
Files 322 321 -1
Lines 21668 21650 -18
==========================================
- Hits 19329 19308 -21
- Misses 2339 2342 +3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show missing libraries that belong to any system packages when possible.
Based on @sergio-costas PR #4293